Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use FQIN in Dockerfile #9842

Merged
merged 1 commit into from
Aug 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/site/Application-generator.md
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ Here are the first two lines of the

```
# Check out https://hub.docker.com/_/node to select a new base image
FROM node:10-slim
FROM docker.io/library/node:18-slim
```

As the comment suggests, the Docker image name is only a default, and you are
Expand Down
2 changes: 1 addition & 1 deletion examples/access-control-migration/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Check out https://hub.docker.com/_/node to select a new base image
FROM node:18-slim
FROM docker.io/library/node:18-slim

# Set to a non-root built-in user `node`
USER node
Expand Down
2 changes: 1 addition & 1 deletion examples/multi-tenancy/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Check out https://hub.docker.com/_/node to select a new base image
FROM node:18-slim
FROM docker.io/library/node:18-slim

# Set to a non-root built-in user `node`
USER node
Expand Down
2 changes: 1 addition & 1 deletion examples/references-many/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Check out https://hub.docker.com/_/node to select a new base image
FROM node:18-slim
FROM docker.io/library/node:18-slim

# Set to a non-root built-in user `node`
USER node
Expand Down
2 changes: 1 addition & 1 deletion examples/rest-crud/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Check out https://hub.docker.com/_/node to select a new base image
FROM node:18-slim
FROM docker.io/library/node:18-slim

# Set to a non-root built-in user `node`
USER node
Expand Down
2 changes: 1 addition & 1 deletion examples/socketio/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Check out https://hub.docker.com/_/node to select a new base image
FROM node:18-slim
FROM docker.io/library/node:18-slim

# Set to a non-root built-in user `node`
USER node
Expand Down
2 changes: 1 addition & 1 deletion examples/todo-jwt/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Check out https://hub.docker.com/_/node to select a new base image
FROM node:18-slim
FROM docker.io/library/node:18-slim

# Set to a non-root built-in user `node`
USER node
Expand Down
2 changes: 1 addition & 1 deletion examples/todo-list/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Check out https://hub.docker.com/_/node to select a new base image
FROM node:18-slim
FROM docker.io/library/node:18-slim

# Set to a non-root built-in user `node`
USER node
Expand Down
2 changes: 1 addition & 1 deletion examples/todo/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Check out https://hub.docker.com/_/node to select a new base image
FROM node:18-slim
FROM docker.io/library/node:18-slim

# Set to a non-root built-in user `node`
USER node
Expand Down
2 changes: 1 addition & 1 deletion packages/cli/generators/app/templates/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Check out https://hub.docker.com/_/node to select a new base image
FROM node:18-slim
FROM docker.io/library/node:18-slim

# Set to a non-root built-in user `node`
USER node
Expand Down