fix(cli): Change to lowercase the project name type by the user #6536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the project generator, when the user use a project name with uppercase letters, the project can not be create because NPM packages has a validation to no allow create packages with uppercase letters. The prompt was update to add a function to transform the values typed by the user to lowecase version and use this value as the project name.
javiersantossanchez
requested review from
agnes512 and
emonddr
as code owners
For the project generator, when the user use a project name with uppercase letters, the project can not be create because NPM packages has a validation to no allow create packages with uppercase letters. The prompt was update to add a function to transform the values typed by the user to lowecase version and use this value as the project name. Signed-off-by: javier santos <[email protected]>
…erator' into fix-use-uppercase-on-project-generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the project generator, when the user uses a project name with uppercase letters, the project can not be created because NPM packages have validation to no allow create packages with uppercase letters.
The prompt was updated to add a function to transform the values typed by the user to the lowercase version and use this value as the project name.
Fixes #1663
#1663
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated