-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: monorepo, package metadata scripts' filepath on Windows #6175
fix: monorepo, package metadata scripts' filepath on Windows #6175
Conversation
bin/check-package-metadata.js
Outdated
@@ -44,7 +44,7 @@ async function checkMonorepoFile(packages, rootPath) { | |||
const monorepoFile = await fs.readFile('docs/site/MONOREPO.md', 'utf8'); | |||
|
|||
for (const p of packages) { | |||
const packagePath = path.relative(rootPath, p.location); | |||
const packagePath = path.relative(rootPath, p.location).replace('\\', '/'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that .replace('\\', '/');
only replaces the first occurrence of \
:
'x\\y\\zz'.replace('\\', '/') => 'x/y\\zz'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use .replace(/\\/g, '/')
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the replace
issue.
382e005
to
871e5d7
Compare
871e5d7
to
0d1e77e
Compare
tsconfig.json
Outdated
@@ -109,6 +109,9 @@ | |||
{ | |||
"path": "extensions/typeorm/tsconfig.json" | |||
}, | |||
{ | |||
"path": "extensions/waterline/tsconfig.json" | |||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert this change.
Signed-off-by: Rifa Achrinza <[email protected]>
0d1e77e
to
f262868
Compare
see: #6155 (comment)
Signed-off-by: Rifa Achrinza [email protected]
Checklist
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈