Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: monorepo, package metadata scripts' filepath on Windows #6175

Conversation

achrinza
Copy link
Member

see: #6155 (comment)

Signed-off-by: Rifa Achrinza [email protected]

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@achrinza achrinza added bug Internal Tooling Issues related to our tooling and monorepo infrastructore labels Aug 22, 2020
@achrinza achrinza self-assigned this Aug 22, 2020
@@ -44,7 +44,7 @@ async function checkMonorepoFile(packages, rootPath) {
const monorepoFile = await fs.readFile('docs/site/MONOREPO.md', 'utf8');

for (const p of packages) {
const packagePath = path.relative(rootPath, p.location);
const packagePath = path.relative(rootPath, p.location).replace('\\', '/');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that .replace('\\', '/'); only replaces the first occurrence of \:

'x\\y\\zz'.replace('\\', '/') => 'x/y\\zz'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use .replace(/\\/g, '/') instead.

Copy link
Contributor

@raymondfeng raymondfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the replace issue.

@achrinza achrinza force-pushed the feat/fixes-monorepo-update-filepath branch from 382e005 to 871e5d7 Compare August 24, 2020 16:56
@achrinza achrinza requested a review from bajtos as a code owner August 24, 2020 16:56
@achrinza achrinza force-pushed the feat/fixes-monorepo-update-filepath branch from 871e5d7 to 0d1e77e Compare August 24, 2020 16:58
tsconfig.json Outdated
@@ -109,6 +109,9 @@
{
"path": "extensions/typeorm/tsconfig.json"
},
{
"path": "extensions/waterline/tsconfig.json"
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change.

@achrinza achrinza force-pushed the feat/fixes-monorepo-update-filepath branch from 0d1e77e to f262868 Compare August 24, 2020 17:22
@raymondfeng raymondfeng merged commit f88cc97 into loopbackio:master Aug 24, 2020
@achrinza achrinza deleted the feat/fixes-monorepo-update-filepath branch August 25, 2020 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Internal Tooling Issues related to our tooling and monorepo infrastructore
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants