Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide @loopback/express from framework-level documentation #5693

Merged
merged 2 commits into from
Jun 9, 2020

Conversation

bajtos
Copy link
Member

@bajtos bajtos commented Jun 9, 2020

  • Update code snippets to import from @loopback/rest instead of @loopback/express.
  • Remove @loopback/express from dependencies of examples/passport-login, it was not used at all.

This is a follow-up for #5659, see also #5550

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

Update code snippets to import from `@loopback/rest` instead
of `@loopback/express`.

Signed-off-by: Miroslav Bajtoš <[email protected]>
@bajtos bajtos added the Docs label Jun 9, 2020
@bajtos bajtos requested a review from raymondfeng June 9, 2020 07:49
@bajtos bajtos self-assigned this Jun 9, 2020
Signed-off-by: Miroslav Bajtoš <[email protected]>
@bajtos bajtos force-pushed the docs/hide-express-pkg branch from 29bda59 to 6294607 Compare June 9, 2020 08:08
@bajtos bajtos changed the title Hide @loopback/express from framework-level documentation Hide @loopback/express from framework-level documentation Jun 9, 2020
@bajtos bajtos added the developer-experience Issues affecting ease of use and overall experience of LB users label Jun 9, 2020
@bajtos bajtos merged commit b59b811 into master Jun 9, 2020
@bajtos bajtos deleted the docs/hide-express-pkg branch June 9, 2020 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer-experience Issues affecting ease of use and overall experience of LB users Docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants