Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] feat(docs): march milestone #4594

Closed
wants to merge 4 commits into from
Closed

Conversation

dhmlau
Copy link
Member

@dhmlau dhmlau commented Feb 8, 2020

Overall theme: finish as much migration guide as possible.

Checklist

👉 Read and sign the CLA (Contributor License Agreement) 👈

  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • API Documentation in code was updated
  • Documentation in /docs/site was updated
  • Affected artifact templates in packages/cli were updated
  • Affected example projects in examples/* were updated

👉 Check out how to submit a PR 👈

@dhmlau dhmlau self-assigned this Feb 8, 2020
@dhmlau dhmlau requested review from raymondfeng and bajtos February 8, 2020 14:46
## Looking for community contributions

_Community contributors: Want to contribute but don't know where to start? Here
is our wish list for this month:_
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Model.toObject() should preserve prototypes (e.g. Date and ObjectID values) #3607

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking from the list of "good first issue" with highest number of upvotes: https://github.com/strongloop/loopback-next/issues?page=1&q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22+sort%3Areactions-%2B1-desc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The list proposed above looks good to me 👍

@@ -45,3 +52,4 @@ is our wish list for this month:_
values) #3607
- [ ] Add support for "include" and "fields" to findById (REST API) #1721
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already supported. I added a test for fields as part of #4745.

@@ -45,3 +52,4 @@ is our wish list for this month:_
values) #3607
- [ ] Add support for "include" and "fields" to findById (REST API) #1721
- [ ] Complex OpenAPI Validations with @property #1624
- [ ] Sugar decorators for Filter and Where parameters #1749
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implemented by #4745

- [ ] Belongs-To relation tries to resolve for foreign key NULL #4372
- [ ] How to build models, repositories and controllers dynamically at runtime
#4296

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the story to update LB3-related docs to accommodate the transition to Maintenance LTS, see strongloop/loopback#4306.

Copy link
Member

@bajtos bajtos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @dhmlau for putting this proposal together ❤️

I like how much progress is planned on the Migration epic 👏

I would like to add the story for LB3 Maintenance LTS to the backlog, to ensure all relevant docs is updated by the end of March. IMO, this is well past due considering that the change happened in Dec last year.

@agnes512
Copy link
Contributor

adding 2 bug fix:
#4751
#4744

@dhmlau
Copy link
Member Author

dhmlau commented Feb 28, 2020

Thanks for everyone's review! I think the March milestone is good to go. We'll commit 37 points.
@agnes512, could you please create a GH issue for that? Thanks. We can use it in the Feb blog.

@dhmlau
Copy link
Member Author

dhmlau commented Feb 29, 2020

Closing this PR as #4767 is opened.

@dhmlau dhmlau closed this Feb 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants