-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] feat(docs): march milestone #4594
Conversation
## Looking for community contributions | ||
|
||
_Community contributors: Want to contribute but don't know where to start? Here | ||
is our wish list for this month:_ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Model.toObject() should preserve prototypes (e.g. Date and ObjectID values) #3607
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking from the list of "good first issue" with highest number of upvotes: https://github.com/strongloop/loopback-next/issues?page=1&q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22+sort%3Areactions-%2B1-desc.
- Add support for "include" and "fields" to findById (REST API) Add support for "include" and "fields" to findById (REST API) #1721
- Best practice for encrypting model properties Best practice for encrypting model properties #2095 . Not sure if this is only good for a very limited set of use cases.
- Complex OpenAPI Validations with
@property
Complex OpenAPI Validations with@property
#1624
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list proposed above looks good to me 👍
@@ -45,3 +52,4 @@ is our wish list for this month:_ | |||
values) #3607 | |||
- [ ] Add support for "include" and "fields" to findById (REST API) #1721 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is already supported. I added a test for fields
as part of #4745.
@@ -45,3 +52,4 @@ is our wish list for this month:_ | |||
values) #3607 | |||
- [ ] Add support for "include" and "fields" to findById (REST API) #1721 | |||
- [ ] Complex OpenAPI Validations with @property #1624 | |||
- [ ] Sugar decorators for Filter and Where parameters #1749 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implemented by #4745
- [ ] Belongs-To relation tries to resolve for foreign key NULL #4372 | ||
- [ ] How to build models, repositories and controllers dynamically at runtime | ||
#4296 | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the story to update LB3-related docs to accommodate the transition to Maintenance LTS, see strongloop/loopback#4306.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dhmlau for putting this proposal together ❤️
I like how much progress is planned on the Migration epic 👏
I would like to add the story for LB3 Maintenance LTS to the backlog, to ensure all relevant docs is updated by the end of March. IMO, this is well past due considering that the change happened in Dec last year.
Thanks for everyone's review! I think the March milestone is good to go. We'll commit 37 points. |
Closing this PR as #4767 is opened. |
Overall theme: finish as much migration guide as possible.
Checklist
👉 Read and sign the CLA (Contributor License Agreement) 👈
npm test
passes on your machinepackages/cli
were updatedexamples/*
were updated👉 Check out how to submit a PR 👈