docs: document Component #2702
Merged
docs: document Component #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacksparrow
force-pushed
the
doc/components
branch
from
1963576 to
07cfecd
Compare
dhmlau
reviewed
Apr 9, 2019
bajtos
suggested changes
Apr 9, 2019
There was a problem hiding this comment.
+1 to have a Components page in Key concepts.
I think it's important to rethink the organization of Component-related content we have for LB4 app developers (component consumers).
IMO:
- "Components" page should provide a light-weight introduction to the concept of a Component
- "Using Components" should go into more details about how to add a component to an application
@bschrammIBM @raymondfeng thoughts?
hacksparrow
force-pushed
the
doc/components
branch
2 times, most recently
from
6789fae to
8431296
Compare
bajtos
suggested changes
Apr 16, 2019
jannyHou
reviewed
Apr 16, 2019
raymondfeng
reviewed
Apr 17, 2019
hacksparrow
force-pushed
the
doc/components
branch
from
8431296 to
80dc867
Compare
|
@bajtos I have updated the content based on your feedback, PTAL. |
bajtos
approved these changes
May 6, 2019
emonddr
approved these changes
May 6, 2019
hacksparrow
force-pushed
the
doc/components
branch
from
80dc867 to
b3f3848
Compare
nabdelgadir
approved these changes
May 6, 2019
Elaborated the Component class
hacksparrow
force-pushed
the
doc/components
branch
from
b3f3848 to
5d7dcd7
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2020.