fix(docs): broken link in Crafting in LB #2361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
nabdelgadir
reviewed
Feb 11, 2019
| @@ -473,7 +473,8 @@ There are several key pillars to make extensibility a reality for LoopBack 4. | |||
| - [Context](Context.md), the IoC container to manage services | |||
| - [Dependency injection](Dependency-injection.md) to facilitate composition | |||
| - [Decorators](Decorators.md) to supply metadata using annotations | |||
| - [Component](Component.md) as the packaging model to bundle extensions | |||
| - [Component](Extending-LoopBack-4.md) as the packaging model to bundle | |||
| extensions | |||
|
|
|||
| Please check out [Extending LoopBack 4](Extending-LoopBack-4.md). | |||
There was a problem hiding this comment.
Should we still keep this?
There was a problem hiding this comment.
I think we should still keep this bullet, because it belongs to There are several key pillars to make extensibility a reality for LoopBack 4.
An alternative link for Component could be https://loopback.io/doc/en/lb4/Using-components.html. then it won't be duplicated what we have after the bullets.
what do you think?
There was a problem hiding this comment.
Yeah, I think that's better so we can avoid duplication.
nabdelgadir
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #2020
This PR is a quick fix in the
Crafting in LoopBackpage for the broken link.As suggested by @bajtos, we'll create a dedicated Component page as a longer term fix.
See #2020 (comment).