Project cleanup #20
Merged
Project cleanup #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix tabbing in loopback/index.js * Remove unused gherkin.ts in root test directory * Lexical order global type definitions * Group test dependencies (expect/sinon) into single global file in root test directory * Modify both mocha.opts to import single global file instead of expect/sinon separately
superkhau
force-pushed
the
refactor/project-cleanup
branch
from
0d04ef9 to
b0a4afc
Compare
bajtos
reviewed
Feb 2, 2017
| global['expect'] = chai.expect; | ||
| global['sinon'] = sinon; |
There was a problem hiding this comment.
👎 ✖️ 💯
Globals are pain to use, didn't we learn that lesson in LoopBack 2.x/3.x yet? See strongloop/loopback#2632.
Please review my proposal on how to fix the problem: #27
There was a problem hiding this comment.
Agreed. This was just a temp solution. #27 LGTM
There was a problem hiding this comment.
@bajtos Yes, it was just a temp solution. +1 for the new testlab package. TY
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tabbing in loopback/index.js
Remove unused gherkin.ts in root test directory
Lexical order global type definitions
Group test dependencies (expect/sinon) into single global file in root
test directory
Modify both mocha.opts to import single global file instead of
expect/sinon separately
cc @ritch