fix(cli): make download-connector-list more robust #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimks
reviewed
Jun 18, 2018
package.json
Outdated
| @@ -18,7 +18,9 @@ | |||
| "coveralls": "^3.0.0", | |||
| "cz-conventional-changelog": "^2.1.0", | |||
| "husky": "^0.14.3", | |||
| "lerna": "^2.9.1" | |||
| "lerna": "^2.9.1", | |||
| "request": "^2.87.0", | |||
There was a problem hiding this comment.
Why do we install these modules at the monorepo level instead of at the package level?
There was a problem hiding this comment.
oops, must've forgot to cd into the package before installing. fixing.
b-admike
approved these changes
Jun 18, 2018
shimks
approved these changes
Jun 19, 2018
Signed-off-by: Taranveer Virk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Taranveer Virk [email protected]
Addressed feedback #1385 (review) regarding making the download function more robust using request module.
Checklist
npm testpasses on your machinepackages/cliwere updatedexamples/*were updated