fix: honor service injection options

Fixes #8357 Signed-off-by: Raymond Feng <[email protected]>
loopbackio · Feb 28, 2022 · 65ec864 · 65ec864
1 parent cc05b13
commit 65ec864
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/packages/core/src/__tests__/acceptance/service.acceptance.ts b/packages/core/src/__tests__/acceptance/service.acceptance.ts
@@ -5,6 +5,7 @@
 
 import {Binding, Context} from '@loopback/context';
 import {expect} from '@loopback/testlab';
+import {types} from 'util';
 import {CoreTags, service} from '../..';
 import {asService} from '../../service';
 
@@ -73,6 +74,20 @@ describe('@service', () => {
     expect(controller.myService).to.be.undefined();
   });
 
+  it('allows asProxyWithInterceptors flag', async () => {
+    class MyController {
+      constructor(
+        @service(MyService, {asProxyWithInterceptors: true})
+        public myService?: MyService,
+      ) {}
+    }
+
+    ctx.bind('controllers.MyController').toClass(MyController);
+
+    const controller = await ctx.get<MyController>('controllers.MyController');
+    expect(types.isProxy(controller.myService)).to.be.true();
+  });
+
   it('allows serviceInterface as a string', async () => {
     class MyController {
       constructor(@service('MyService') public myService: MyService) {}

diff --git a/packages/core/src/service.ts b/packages/core/src/service.ts
@@ -109,7 +109,11 @@ export function service(
         );
       }
       const view = new ContextView(ctx, filterByServiceInterface(serviceType));
-      const result = view.resolve(session);
+      const result = view.resolve({
+        optional: metadata?.optional,
+        asProxyWithInterceptors: metadata?.asProxyWithInterceptors,
+        session,
+      });
 
       const serviceTypeName =
         typeof serviceType === 'string'