refactor: apply feedback

loopbackio · Aug 14, 2019 · 594a743 · 594a743
1 parent 492a4ba
commit 594a743
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 17 deletions.
diff --git a/packages/authorization/src/__tests__/unit/authorize-decorator.test.ts b/packages/authorization/src/__tests__/unit/authorize-decorator.test.ts
@@ -8,7 +8,7 @@ import {
   AUTHENTICATED,
   authorize,
   EVERYONE,
-  getAuthorizeMetadata,
+  getAuthorizationMetadata,
   UNAUTHENTICATED,
 } from '../..';
 
@@ -23,13 +23,13 @@ describe('Authentication', () => {
         update() {}
       }
 
-      let metaData = getAuthorizeMetadata(TestClass, 'getSecret');
+      let metaData = getAuthorizationMetadata(TestClass, 'getSecret');
       expect(metaData).to.eql({
         allowedRoles: ['ADMIN'],
         scopes: ['secret.read'],
       });
 
-      metaData = getAuthorizeMetadata(TestClass, 'update');
+      metaData = getAuthorizationMetadata(TestClass, 'update');
       expect(metaData).to.eql({
         allowedRoles: ['OWNER'],
         scopes: ['data.update'],
@@ -45,13 +45,13 @@ describe('Authentication', () => {
         update() {}
       }
 
-      let metaData = getAuthorizeMetadata(TestClass, 'getSecret');
+      let metaData = getAuthorizationMetadata(TestClass, 'getSecret');
       expect(metaData).to.eql({
         allowedRoles: ['ADMIN'],
         scopes: ['secret.read'],
       });
 
-      metaData = getAuthorizeMetadata(TestClass, 'update');
+      metaData = getAuthorizationMetadata(TestClass, 'update');
       expect(metaData).to.eql({
         allowedRoles: ['OWNER'],
         scopes: ['data.update'],
@@ -68,13 +68,13 @@ describe('Authentication', () => {
         update() {}
       }
 
-      let metaData = getAuthorizeMetadata(TestClass, 'getSecret');
+      let metaData = getAuthorizationMetadata(TestClass, 'getSecret');
       expect(metaData).to.eql({
         allowedRoles: ['ADMIN'],
         scopes: ['secret.read'],
       });
 
-      metaData = getAuthorizeMetadata(TestClass, 'update');
+      metaData = getAuthorizationMetadata(TestClass, 'update');
       expect(metaData).to.eql({
         allowedRoles: ['OWNER'],
         scopes: ['data.update'],
@@ -87,7 +87,7 @@ describe('Authentication', () => {
         getSecret() {}
       }
 
-      const metaData = getAuthorizeMetadata(TestClass, 'getSecret');
+      const metaData = getAuthorizationMetadata(TestClass, 'getSecret');
       expect(metaData).to.eql({
         allowedRoles: [EVERYONE],
       });
@@ -99,7 +99,7 @@ describe('Authentication', () => {
         getSecret() {}
       }
 
-      const metaData = getAuthorizeMetadata(TestClass, 'getSecret');
+      const metaData = getAuthorizationMetadata(TestClass, 'getSecret');
       expect(metaData).to.eql({
         allowedRoles: [EVERYONE],
         deniedRoles: ['xyz'],
@@ -112,7 +112,7 @@ describe('Authentication', () => {
         getSecret() {}
       }
 
-      const metaData = getAuthorizeMetadata(TestClass, 'getSecret');
+      const metaData = getAuthorizationMetadata(TestClass, 'getSecret');
       expect(metaData).to.eql({
         deniedRoles: [EVERYONE],
       });
@@ -124,7 +124,7 @@ describe('Authentication', () => {
         getSecret() {}
       }
 
-      const metaData = getAuthorizeMetadata(TestClass, 'getSecret');
+      const metaData = getAuthorizationMetadata(TestClass, 'getSecret');
       expect(metaData).to.eql({
         allowedRoles: ['xyz'],
         deniedRoles: [EVERYONE],
@@ -137,7 +137,7 @@ describe('Authentication', () => {
         getSecret() {}
       }
 
-      const metaData = getAuthorizeMetadata(TestClass, 'getSecret');
+      const metaData = getAuthorizationMetadata(TestClass, 'getSecret');
       expect(metaData).to.eql({
         allowedRoles: [AUTHENTICATED],
       });
@@ -149,7 +149,7 @@ describe('Authentication', () => {
         getSecret() {}
       }
 
-      const metaData = getAuthorizeMetadata(TestClass, 'getSecret');
+      const metaData = getAuthorizationMetadata(TestClass, 'getSecret');
       expect(metaData).to.eql({
         deniedRoles: [UNAUTHENTICATED],
       });
@@ -168,7 +168,7 @@ describe('Authentication', () => {
         getSecret() {}
       }
 
-      const metaData = getAuthorizeMetadata(TestClass, 'getSecret');
+      const metaData = getAuthorizationMetadata(TestClass, 'getSecret');
       expect(metaData).to.deepEqual({
         voters: ['v1', 'v2'],
         allowedRoles: ['a1', 'a3', 'a2'],

diff --git a/packages/authorization/src/authorize-interceptor.ts b/packages/authorization/src/authorize-interceptor.ts
@@ -16,7 +16,7 @@ import {
   Provider,
 } from '@loopback/context';
 import * as debugFactory from 'debug';
-import {getAuthorizeMetadata} from './decorators/authorize';
+import {getAuthorizationMetadata} from './decorators/authorize';
 import {AuthorizationTags} from './keys';
 import {
   AuthorizationContext,
@@ -42,7 +42,7 @@ export class AuthorizationInterceptor implements Provider<Interceptor> {
 
   async intercept(invocationCtx: InvocationContext, next: Next) {
     const description = debug.enabled ? invocationCtx.description : '';
-    const metadata = getAuthorizeMetadata(
+    const metadata = getAuthorizationMetadata(
       invocationCtx.target,
       invocationCtx.methodName,
     );

diff --git a/packages/authorization/src/decorators/authorize.ts b/packages/authorization/src/decorators/authorize.ts
@@ -197,7 +197,7 @@ export namespace authorize {
  * @param target Target object/class
  * @param methodName Target method
  */
-export function getAuthorizeMetadata(
+export function getAuthorizationMetadata(
   target: object,
   methodName: string,
 ): AuthorizationMetadata | undefined {