fix(sequelize): resolves SQL error when order filter is an empty string

Signed-off-by: KalleV <[email protected]>
loopbackio · Dec 29, 2023 · 56201c5 · 56201c5
1 parent 74aa049
commit 56201c5
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/extensions/sequelize/src/__tests__/integration/repository.integration.ts b/extensions/sequelize/src/__tests__/integration/repository.integration.ts
@@ -487,6 +487,23 @@ describe('Sequelize CRUD Repository (integration)', () => {
       expect(getResponse.body).to.be.deepEqual(reversedArray);
     });
 
+    it('ignores an empty `order` filter', async () => {
+      const users = [
+        getDummyUser({name: 'ABoy'}),
+        getDummyUser({name: 'BBoy'}),
+        getDummyUser({name: 'CBoy'}),
+      ];
+      const createAllResponse = await client.post('/users-bulk').send(users);
+      const filter = {
+        order: '',
+      };
+      const getResponse = await client.get(`/users`).query({
+        filter,
+      });
+
+      expect(getResponse.body).to.be.deepEqual(createAllResponse.body);
+    });
+
     it('supports `limit` filter', async () => {
       const users = [getDummyUser(), getDummyUser(), getDummyUser()];
       await client.post('/users-bulk').send(users);

diff --git a/extensions/sequelize/src/sequelize/sequelize.repository.base.ts b/extensions/sequelize/src/sequelize/sequelize.repository.base.ts
@@ -489,7 +489,7 @@ export class SequelizeCrudRepository<
    * @returns Sequelize compatible order filter value
    */
   protected buildSequelizeOrder(order?: string[] | string): Order | undefined {
-    if (order === undefined) {
+    if (order === undefined || order === '') {
       return undefined;
     }