Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix discovering relations #2340

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Fix discovering relations #2340

merged 1 commit into from
Dec 5, 2024

Conversation

thiscode
Copy link
Contributor

fix #2339

@thiscode thiscode requested a review from dhmlau as a code owner November 26, 2024 04:36
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12023910577

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.715%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/datasource.js 0 1 0.0%
Totals Coverage Status
Change from base Build 12003460125: 0.0%
Covered Lines: 7281
Relevant Lines: 8287
💛 - Coveralls

dhmlau
dhmlau approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thiscode, thanks for the fix. Your change LGTM.
I wonder why our tests didn't catch that earlier, possibly there's no test coverage on that.

@dhmlau
Copy link
Member

dhmlau commented Dec 4, 2024

Just realized there's commit lint error. Could you please take a look at that? Thanks.
One suggestion on the commit message would be:

fix: fix discovering relation

@dhmlau dhmlau force-pushed the fix/repair-discover-foreign-keys branch from 7dd0006 to 72d882a Compare December 5, 2024 14:04
@thiscode @dhmlau
fix: fix discovering relations
6f02dd7 
Signed-off-by: Thomas Miliopoulos <[email protected]>
@dhmlau dhmlau force-pushed the fix/repair-discover-foreign-keys branch from 72d882a to 6f02dd7 Compare December 5, 2024 14:04
@dhmlau
Copy link
Member

dhmlau commented Dec 5, 2024

@thiscode, I fixed the commit message, and merging this PR now. Thanks!

@dhmlau dhmlau merged commit 11e5dcf into loopbackio:master Dec 5, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaqilniz aaqilniz aaqilniz approved these changes

@dhmlau dhmlau dhmlau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

the function discoverSchemas no longer discover any relations
4 participants
@thiscode @coveralls @dhmlau @aaqilniz