Improve Model type definitions #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bajtos
requested review from
b-admike,
dhmlau,
jannyHou,
virkt25 and
zbarbuto
as code owners
9 tasks
bajtos
commented
Jan 24, 2019
| @@ -19,17 +19,17 @@ export type PropertyType = | |||
| * Property definition | |||
| */ | |||
| export interface PropertyDefinition extends AnyObject { | |||
| name: string; | |||
There was a problem hiding this comment.
AFAICT, the property name is always stored as the key in property map (name => definition).
raymondfeng
reviewed
Jan 24, 2019
Define two new types: ModelSettings and ModelProperties to describe the objects describing model properties and settings. Add static property `base` and static method `extend` to the definition of `ModelBase` class. Add property `defaultModelBaseClass` to `ModelBuilder` class definition. Fix `PropertyDefinition` interface: remove `name`, add optional `id`.
|
@raymondfeng LGTY now? |
raymondfeng
approved these changes
Jan 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
baseand static methodextendto the definitionof
ModelBaseclass.defaultModelBaseClasstoModelBuilderclass definition.PropertyDefinitioninterface: removename, add optionalid.These issues were discovered while working on loopbackio/loopback-next#2274.
Checklist
guide