Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: query to fetch unique columns #520

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: query to fetch unique columns #520

wants to merge 1 commit into from

Conversation

aaqilniz
Copy link
Contributor

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@coveralls
Copy link

coveralls commented Apr 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 8689340015

Details

  • 2 of 11 (18.18%) changed or added relevant lines in 1 file are covered.
  • 9 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.5%) to 58.772%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/sql.js 2 11 18.18%
Files with Coverage Reduction New Missed Lines %
lib/sql.js 9 50.24%
Totals Coverage Status
Change from base Build 8688690237: -0.5%
Covered Lines: 715
Relevant Lines: 1146
💛 - Coveralls

@aaqilniz aaqilniz force-pushed the feat/unique-index branch from b7fea3b to 514630b Compare April 15, 2024 12:45
@aaqilniz aaqilniz marked this pull request as ready for review June 25, 2024 08:12
@aaqilniz aaqilniz requested a review from dhmlau as a code owner June 25, 2024 08:12
@dhmlau
Copy link
Member

dhmlau commented Aug 14, 2024

Thanks @aaqilniz for the PR. Could you please add some tests for the changes? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarpanB samarpanB samarpanB approved these changes

@dhmlau dhmlau Awaiting requested review from dhmlau dhmlau is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aaqilniz @coveralls @dhmlau @samarpanB