Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template installation docs #898

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yaauie
Copy link
Contributor

@yaauie yaauie commented Nov 18, 2019

Includes #867 with changelog and version bump.

lucabelluccini and others added 2 commits November 18, 2019 20:47
Clarify Template file is not monitored.
Clarify when the Template is installed and what conditions apply.
Copy link
Member

@jsvd jsvd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested a minor additional detail on the explanation.
This PR will have to be rebased and the version re-bumped.

@@ -707,6 +707,9 @@ https://www.cs.utexas.edu/~shmat/shmat_ccs12.pdf
You can set the path to your own template here, if you so desire.
If not set, the included template will be used.

Note that Logstash will not monitor the template file for changes.
The template file will be read when its installation is triggered.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The template file will be read when its installation is triggered.
The template file will be read when its installation is triggered, which happens at the startup of a pipeline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants