Handle MissingConverterException errors #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With certain JMS providers, the JMS headers may include values that cannot be handled and added to an event, which currently throw either a MissingConverterException or an IllegalArgumentException. This commit attempts to handle these errors more gracefully by calling `to_s` and attempting to use the string representation rather than crash the plugin
jsvd
approved these changes
Mar 24, 2020
| # And IllegalArgumentException, which are used across different | ||
| # Logstash versions for Valuefier errors | ||
| logger.warn("Unable to convert value of type #{value.class} for field #{field}, falling back to using string representation", | ||
| :exception => e) |
There was a problem hiding this comment.
Suggested change
| :exception => e) | |
| :exception => e.class, :message => e.message) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With certain JMS providers, the JMS headers may include values that
cannot be handled and added to an event, which currently throw either
a MissingConverterException or an IllegalArgumentException. This commit
attempts to handle these errors more gracefully by calling
to_sandattempting to use the string representation rather than crash the plugin