fix: babbles messages #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vojtechsimetka
approved these changes
Dec 5, 2023
Comment on lines
+129
to
+131
| // this is a workaround for the case when the parent is lost to | ||
| // keep the rest of the thread | ||
| roots.push(parent) |
There was a problem hiding this comment.
Is this a temporary fix? If so, I suggest adding //FIXME: or //TODO:
There was a problem hiding this comment.
Well, for now it is a workaround for lost messages.
However there is a broader issue that we only keep MAX_MESSAGES (currently set to 100) messages locally in the history. This is not a big issue with chats because they are linear, but with babbles it is possible that a parent message is lost because of this and the conversation would be orphaned without this workaround too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes messages disappear from the waku store. This is a fix for the case if a message's parent is lost to keep at least the rest of the thread.