Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined name #469

Merged
merged 2 commits into from
Oct 11, 2023
Merged

fix: undefined name #469

merged 2 commits into from
Oct 11, 2023

Conversation

agazso
Copy link
Contributor

@agazso agazso commented Oct 10, 2023

This PR fixes undefined names in 3 places:

  • chat list
  • chat view header
  • group chat edit page

First I tried to truncate the address with CSS, but it required different solutions in each pages, so eventually just settled on truncating in the userDisplayName function.

Before:
Screenshot from 2023-10-10 17-30-47

After:
Screenshot from 2023-10-10 17-48-11

@vercel
Copy link

vercel bot commented Oct 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
waku-objects-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 10, 2023 3:50pm

@agazso agazso merged commit fe24f5c into main Oct 11, 2023
2 checks passed
@agazso agazso deleted the fix/undefined-name branch October 11, 2023 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants