fix: group chat editing (#499)

src/lib/adapters/waku/crypto.ts

@@ -82,3 +82,7 @@ export function privateKeyToPublicKey(privateKey: Hex | Uint8Array): Hex {
 	const publicKeyBytes = getPublicKey(privateKey)
 	return bytesToHex(publicKeyBytes)
 }
+
+export function arePublicKeysEqual(pkA: Hex | Uint8Array, pkB: Hex | Uint8Array): boolean {
+	return compressPublicKey(pkA) === compressPublicKey(pkB)
+}

src/lib/adapters/waku/index.ts

@@ -54,7 +54,7 @@ import { balanceStore } from '$lib/stores/balances'
 import type { ContentTopic } from './waku'
 import { installedObjectStore } from '$lib/stores/installed-objects'
 import { errorStore } from '$lib/stores/error'
-import { compressPublicKey, fixHex, getSharedSecret, hash } from './crypto'
+import { arePublicKeysEqual, compressPublicKey, fixHex, getSharedSecret, hash } from './crypto'
 import { bytesToHex, hexToBytes } from '@waku/utils/bytes'
 import { encrypt, decrypt } from './crypto'
 import {
@@ -855,7 +855,9 @@ export default class WakuAdapter implements Adapter {
 			return
 		}
 
-		if (compressPublicKey(decodedMessage.signaturePublicKey) !== fixHex(profilePublicKey)) {
+		if (
+			!arePublicKeysEqual(compressPublicKey(decodedMessage.signaturePublicKey), profilePublicKey)
+		) {
 			console.error('invalid signature', {
 				decodedMessage,
 				profilePublicKey,
@@ -970,12 +972,10 @@ export default class WakuAdapter implements Adapter {
 					return
 				}
 
+				const signaturePublicKey = compressPublicKey(decodedMessage.signaturePublicKey)
+
 				// check if the signature matches a member of the group
-				if (
-					!chat.users
-						.map((user) => user.publicKey)
-						.includes(bytesToHex(decodedMessage.signaturePublicKey))
-				) {
+				if (!chat.users.map((user) => fixHex(user.publicKey)).includes(signaturePublicKey)) {
 					return
 				}
 

src/routes/group/chat/[id]/edit/+page.svelte

@@ -33,8 +33,6 @@
 	import { userDisplayName } from '$lib/utils/user'
 	import { errorStore } from '$lib/stores/error'
 
-	$: console.log($chats)
-
 	$: chatId = $page.params.id
 	$: groupChat = $chats.chats.get(chatId)
 	let picture: string | undefined