feat: estimate addExpense cost even if we don't have splitter deployed

src/lib/objects/split/blockchain.ts

@@ -119,14 +119,23 @@ export async function addExpense(
 
 export async function estimateAddExpense(
 	getContract: GetContract,
-	splitterAddress: string,
+	splitterAddress: string | undefined,
 	amount: bigint,
 	from: string,
 	members: string[],
 	metadata = '0x0000000000000000000000000000000000000000',
 ): Promise<bigint> {
-	const splitter = getSplitterContract(getContract, splitterAddress)
-	const gasEstimate: bigint = await splitter.addExpense.estimateGas(metadata, amount, from, members)
+	let gasEstimate: bigint
+	let splitter: Splitter
+	if (splitterAddress) {
+		splitter = getSplitterContract(getContract, splitterAddress)
+		gasEstimate = await splitter.addExpense.estimateGas(metadata, amount, from, members)
+	} else {
+		// This is worse case estimateAddExpense cost
+		// we can not do it by estimating the transaction because we don't have the splitter contract deployed and the transaction would fail in the master splitter contract
+		gasEstimate = 47530n + 9000n * BigInt(members.length - 2)
+		splitter = getSplitterContract(getContract, await getMasterSplitterContractAddress(getContract))
+	}
 
 	const provider = splitter.runner?.provider
 	if (!provider) throw new Error('Could not estimate transaction fee')

src/lib/objects/split/views/summary.svelte

@@ -46,32 +46,19 @@
 	async function estimateFee(users: User[], amount: string, token: Token) {
 		const members = users.map((u) => u.address)
 		let amnt = toBigInt(amount, token.decimals)
-		fee = 0n
+		let fee = 0n
 		let splitContractAddress = splitterAddress
 
-		try {
-			if (!splitContractAddress) {
-				fee = await estimateCreateSplitterContract(getContract, members)
-
-				splitContractAddress = await getMasterSplitterContractAddress(getContract)
-			}
-		} catch (error) {
-			console.log('e1', error)
-		}
-
-		if (!splitContractAddress) throw new Error('No splitter address')
-
-		try {
-			fee += await estimateAddExpense(
-				getContract,
-				splitContractAddress,
-				amnt,
-				profile.address,
-				members,
-			)
-		} catch (error) {
-			console.log('e2', error)
+		if (!splitContractAddress) {
+			fee = await estimateCreateSplitterContract(getContract, members)
 		}
+		fee += await estimateAddExpense(
+			getContract,
+			splitContractAddress,
+			amnt,
+			profile.address,
+			members,
+		)
 
 		return fee
 	}