feat: add support for enterprise and child organizations #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakedipity
force-pushed
the
jakedipity/LOG-13116
branch
from
92cc2a3 to
1db1e5e
Compare
jakedipity
force-pushed
the
jakedipity/LOG-13116
branch
from
1db1e5e to
98e0cbb
Compare
jsumners
reviewed
Dec 23, 2022
logdna/common_test.go
Outdated
| copy(opts, args) | ||
| sk, ul := opts[0], opts[1] | ||
| sk, ul, tp := opts[0], opts[1], opts[2] |
There was a problem hiding this comment.
What do you think of renaming these variables to something that imparts meaning? From the following fmt.Sprintf, it looks like sk => serviceKey would make sense. I have no idea what the other two variables would be (the crux of the issue).
Comment on lines
+64
to
+72
| func buildSchemaMap(a []TerraformInfo) map[string]*schema.Resource { | ||
| m := make(map[string]*schema.Resource) | ||
|
|
||
| for _, e := range a { | ||
| m[e.name] = e.schema | ||
| } | ||
|
|
||
| return m | ||
| } |
There was a problem hiding this comment.
Suggested change
| func buildSchemaMap(a []TerraformInfo) map[string]*schema.Resource { | |
| m := make(map[string]*schema.Resource) | |
| for _, e := range a { | |
| m[e.name] = e.schema | |
| } | |
| return m | |
| } | |
| func buildSchemaMap(tfInfoList []TerraformInfo) map[string]*schema.Resource { | |
| schemaMap := make(map[string]*schema.Resource) | |
| for _, info := range tfInfoList { | |
| schemaMap[info.name] = info.schema | |
| } | |
| return schemaMap | |
| } |
Mainly, the a doesn't impart any information to the reader. Renaming the m and e variables would also really help the next person to look at this code.
jakedipity
force-pushed
the
jakedipity/LOG-13116
branch
4 times, most recently
from
1b28fa9 to
3a399a0
Compare
jakedipity
force-pushed
the
jakedipity/LOG-13116
branch
from
3a399a0 to
dd9048b
Compare
|
@jakedipity Mezmo laid me off on January 19. Please request a review from someone else. |
|
@jakedipity , you could add @seeruyy |
jakedipity
force-pushed
the
jakedipity/LOG-13116
branch
from
dd9048b to
2852809
Compare
|
Yeah sorry, that was a misclick on my part. |
This begins support for terraform management of enterprise and child organizations: * Allows the provider to accept an enterprise key to indicate an enterprise organization. * Enterprise organizations can attach and detach child organizations. Ref: LOG-13116 Signed-off-by: Jacob Hull <[email protected]>
jakedipity
force-pushed
the
jakedipity/LOG-13116
branch
from
d85de8c to
8441d12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This begins support for terraform management of enterprise and child organizations:
Ref: LOG-13116
Signed-off-by: Jacob Hull [email protected]