Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor: Make info banner on health route less specific #851

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Minor: Make info banner on health route less specific #851

merged 1 commit into from
Oct 15, 2024

Conversation

vishnuMohanan01
Copy link
Contributor

@vishnuMohanan01 vishnuMohanan01 commented Oct 15, 2024 •
edited
Loading

Screenshot 2024-10-15 at 11 10 20 AM

It should actually be generic and say "Database" instead. Read in doc.

Reasons:

  • In code, we are pinging the configured db and redis to check health. It's not specific to postgres.
  • Context in the guide is explained setting sqlite as db provider. So it will be weird to see "Postgres" for readers who chose sqlite while they read through.
Screenshot 2024-10-15 at 11 17 30 AM

@vishnuMohanan01 vishnuMohanan01 marked this pull request as ready for review October 15, 2024 05:52
@kaplanelad kaplanelad merged commit 65e8062 into loco-rs:master Oct 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaplanelad kaplanelad kaplanelad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vishnuMohanan01 @kaplanelad