Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some clarifying instructions to the getting started page #816

Merged
merged 4 commits into from
Oct 13, 2024

Conversation

isaacdonaldson
Copy link
Contributor

Looking at some feedback, it seems there is some confusion around some of the configuration options (#801). This PR adds a couple sections to explain the differences in the getting started mini-tour depending on what option was chosen, as well as being explicit in needing to build the frontend/ directory with the default.

Also worth noting: I changed the 127.0.0.1 host to be localhost to be consistent with the rest of the page (and work better on a copy/paste). I also added spaces under the infobox div's because it was not highlighting the code in the backticks properly. This does cause the information icon to not be inline, but that is less important than being able to see the highlighting.

Copy link

@yonas yonas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/posts should be /api/posts

@isaacdonaldson
Copy link
Contributor Author

/posts should be /api/posts

Not the case all the time. I'm working on a PR that might address this, but currently, the routes that come with the starters are behind /api but the ones created by the generator do not have the /api prefix. At least this is true of version 0.9.

@jondot jondot merged commit 9a83331 into loco-rs:master Oct 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants