Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CC and BCC field to the mailers. #599

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Conversation

BWStearns
Copy link
Contributor

Add a bcc field to Emails for the mailers.

@BWStearns
Copy link
Contributor Author

I haven't tested it end to end yet. Will comment when I have. Other than the existing email test in email_sender is there another place it should be tested in code?

@BWStearns
Copy link
Contributor Author

Unfortunately sendgrid removed bcc so I don't have a convenient way to test this end to end at the moment.

@jondot
Copy link
Contributor

jondot commented Jun 4, 2024

Looks good. Should we also add cc for completeness?

PS I like using mailtutan (written in rust) or mailhog for development. It’s really nice.

@BWStearns
Copy link
Contributor Author

I was just thinking I should add cc as well. I’ll do that tomorrow after work. Getting a bit late here.

Thanks for the recommendation. I’ll give it a go.

@BWStearns
Copy link
Contributor Author

It at least doesn't error but I'm getting this in mailtutan:

[
    {
        "id": 1,
        "sender": "Someone [email protected]",
        "recipients": [
            "[email protected]"
        ],
        "subject": "Welcome brian\n",
        "created_at": "2024-06-04 23:30:32",
        "attachments": [],
        "formats": [
            "source",
            "html",
            "plain"
        ]
    }
]

A quick search of their codebase says there's no cc or bcc in their codebase. Are these headers just not supported in mailtutan?

@BWStearns
Copy link
Contributor Author

image

Ok so CC works. I'm not seeing the bcc header but it looks like mailhog doesn't support it either. I think this looks good?

@BWStearns BWStearns changed the title Add BCC field to the mailers. Add CC and BCC field to the mailers. Jun 5, 2024
@jondot
Copy link
Contributor

jondot commented Jun 5, 2024

yea lets go for it, thanks!

@jondot jondot merged commit 54a7828 into loco-rs:master Jun 5, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants