-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): pretty-print cargo loco routes #1073
Conversation
Thank you, @AngelOnFira, for this PR! We aim to minimize the number of external crates to reduce the binary size and compilation time. If you can think of an alternative implementation that doesn’t rely on an external crate, that would be fantastic. Looking forward to your thoughts! |
Thanks for the quick reply! I mainly wanted to just give this a test first with the dependency, but I can definitely slim it down to not use anything external. I'll ping you once I get that in order! :) |
Here is a simple improvement:
But I'm curious if a view like this might be a bit more natural to read:
I'm going to do an iteration on that to make it a bit more clear, and maybe add some colour. |
f07a137
to
649c097
Compare
This should be ready now @kaplanelad! 🦀 |
@AngelOnFira this is beautiful, thanks! |
Thanks, @AngelOnFira, it looks much better! The event from the table is also great! :) Could you please take a look at my comment and also address the CI issue? By the way, we have a few more commands (beyond prints) that could benefit from a design update:
We’d really appreciate it if you could open another PR (no need in this PR) to apply your magic to these as well! |
649c097
to
d106373
Compare
Thanks for the feedback!
CI should be resolved (but I think I need a maintainer to allow it to run again). I'm not sure I saw a separate comment, I might have missed it somewhere. Did you mean to point something else out?
Awesome, thanks for the list! I've mostly used |
@AngelOnFira
and use colored this is exists in cargo.toml Thanks |
d106373
to
0699e53
Compare
Ah yes, that makes a lot of sense. That should be fixed now! 🙌🏻 |
I'll get CI working now |
45f6a99
to
392ace3
Compare
392ace3
to
b42cd12
Compare
I was testing CI locally on my fork, and it looks like everything should pass now 🎉 I was having some issues with Mac, and temp directories, so I'll upstream some test fixes in another PR hopefully. |
beautiful! merging! |
This add cleaner formatting to the
cargo loco routes
command.