Fix config schema error #629 #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finnlewis
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Confirmed that the test work with:
ddev composer require "localgovdrupal/localgov:dev-feature/740/enable-localgov_base-helper-module as 3.0.10" -W
ddev composer require "localgovdrupal/localgov_base:dev-fix/1.x/629-schema-errors as 1.7.0" -W
ddev phpunit web/themes/contrib/localgov_base
Giving:
Testing /var/www/html/web/themes/contrib/localgov_base
.. 2 / 2 (100%)
Time: 00:27.639, Memory: 4.00 MB
OK (2 tests, 6 assertions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #629. Should allow the 1.7.0 release #622 to progress.
What does this change?
There isn't an
enumschema type so usingstringinstead with a constraint.How to test
Checkout this branch and the
feature/740/enable-localgov_base-helper-modulebranch from localgov, as used here: localgovdrupal/localgov#741. Then run the tests in this module.Not using the profile branch results in test failing with message: Unable to install theme: 'localgov_base' due to unmet module dependencies: 'localgov_base_helper'.