-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deprecations, replace cookies with localstorage #322
base: 1.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @millnut. I still think we can rewrite the cookie logic to not require js-cookie if someone has time. |
Is this template actully used anywhere? it does not appear in any other custom entitiy. Maybe thats why we havn't noticed it. |
Thanks for checking @andybroomfield I wasn't aware it used a remote CDN. If I have the time I'll rewrite in plain javascript and we can probably remove this requirement altogether |
Is this still draft? Notice similar but different work on #347 |
Yep still draft I need to do some checks on the tests |
spaceless
that was missed (see https://www.drupal.org/project/drupal/issues/3094850)full-page-alert-banner.es6.js
, Drupal doesn't use es6 for builds anymore