Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates patch for preview link #759

Merged
merged 1 commit into from
Aug 15, 2024
Merged

updates patch for preview link #759

merged 1 commit into from
Aug 15, 2024

Conversation

markconroy
Copy link
Member

What does this change?

Preview Link has had a new release, so I had to re-roll the patch that is against it for "Copy to clipboard". This updates the patch that we can now use.


Thanks to Big Blue Door for sponsoring my time to work on this.

@AWearring
Copy link
Contributor

Hmm, doesn't work for me on my local build
In Firefox I get an Uncaught TypeError: navigator.clipboard is undefined error
In Chrome I get Uncaught TypeError: Cannot read properties of undefined (reading 'writeText')

@AWearring
Copy link
Contributor

AWearring commented Aug 15, 2024

Hmm, doesn't work for me on my local build In Firefox I get an Uncaught TypeError: navigator.clipboard is undefined error In Chrome I get Uncaught TypeError: Cannot read properties of undefined (reading 'writeText')

It appears that this could be an issue with my local virtual PC - having reinstalled the previous version of preview link (and patch) I get the same errors - this version works on our staging and live sites

@finnlewis
Copy link
Member

Patch applies for me and the preview link functionality appears to work as expected.

@finnlewis finnlewis merged commit e370c93 into 3.x Aug 15, 2024
8 checks passed
@finnlewis finnlewis deleted the fix/758/preview-link-patch branch August 15, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants