Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new install step, which calls a new hook. #751

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

rupertj
Copy link
Member

@rupertj rupertj commented Jul 31, 2024

What does this change?

Adds a new step to the installer, which calls a new hook (hook_localgov_post_install) to let other modules perform tasks.

How to test

Use the version of localgov_core from this MR: localgovdrupal/localgov_core#212. That will implement the hook in this MR and use it to set up blocks in the installer.

rupertj added 2 commits July 31, 2024 13:11
…tall), so modules can run tasks at the end of a site install.
@rupertj
Copy link
Member Author

rupertj commented Aug 1, 2024

See the instructions in this MR for how to test this: localgovdrupal/localgov_core#212

Copy link
Member

@stephen-cox stephen-cox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks to me to be a nice solution to the problems found in localgovdrupal/localgov_core#212

Would be nice to have @ekes input as well, but happy to approve.

Copy link
Member

@ekes ekes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me, just reminds me we really must find the time to start working on moving to recipes already. Because this sort of thing I think we'll have to do differently.

@ekes ekes merged commit bd1b3b9 into 3.x Aug 6, 2024
8 checks passed
@ekes ekes deleted the feature/3.x/750-add-install-step branch August 6, 2024 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants