-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest version of the unpublised content access patch #678
Update to latest version of the unpublised content access patch #678
Conversation
Fix #670 Uses the patch in comment 87. This is the evolution of our current patch, rather than the shortned version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the patch failure which makes me think we should get it sooner than later, but I get different test failures on the update test, so perhaps someone else can double check @finnlewis @ekes @Adnan-cds?
The new patch applies, but when running phpunit tests locally, I get:
Edit: I also get the same error without the patch. |
The patch works, I have created a separate issue for the error I get: #680 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should merge this, make a release, then fix the failing tests which look to be unrelated.
Fix #670
Uses the patch in comment 87.
This is the evolution of our current patch, rather than the shortned version.