Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch entity_browser to address PHP 8.2 test failures. #642

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Patch entity_browser to address PHP 8.2 test failures. #642

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05a9ec3
Patch entity_browser to address PHP 8.2 test failures.
finnlewis Nov 9, 2023
a4846f8
Add drupal/entity_browser to patch it here.
finnlewis Nov 9, 2023
dea8ca3
Merge branch '3.x' into fix/636-entity-browser-php82-tests
andybroomfield Nov 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@
"drupal/gin": "^3.0@alpha",
"drupal/gin_login": "^2.0.3",
"drupal/gin_toolbar": "^1.0@beta",
"drupal/entity_browser": "^2.9",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it seems so! I think it only patches if the require is in the same composer.json

I'm still not 100% sure though.

Here's a test run without the require which has failures:
https://github.com/localgovdrupal/localgov/actions/runs/6810487415

Here's the one with the require, which passed:
https://github.com/localgovdrupal/localgov/actions/runs/6810600296

"drupal/preview_link": "^2.1@alpha",
"drupal/simple_sitemap": "^4.1",
"drupal/search_api": "^1.21",
Expand Down Expand Up @@ -60,6 +61,9 @@
},
"drupal/core": {
"Users can't reference unpublished content even when they have access to it. See https://www.drupal.org/project/drupal/issues/2845144": "https://www.drupal.org/files/issues/2022-06-17/2845144-67.patch"
},
"drupal/entity_browser": {
"Fix PHP 8.2 deprecation issue with WidgetSelectorBase-class, https://www.drupal.org/project/entity_browser/issues/3350169": "https://www.drupal.org/files/issues/2023-06-15/3350169-8_0.patch"
}
}
}
Expand Down
Loading