Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #253

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JonathanDHolden
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for inspiring-euclid-d918c8 ready!

Name Link
🔨 Latest commit 210c6e9
🔍 Latest deploy log https://app.netlify.com/sites/inspiring-euclid-d918c8/deploys/669619526d45d20008254f97
😎 Deploy Preview https://deploy-preview-253--inspiring-euclid-d918c8.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@finnlewis
Copy link
Member

Hi @JonathanDHolden

Thanks for this, but not sure what we can do with this pull request as it doesn't seem to fix the problem.

Looking at the commit, I guess there is a broken link that needs updating, probably to https://docs.localgovdrupal.org/devs/workflows/installing-and-deploying-lgd.html

Would you like to amend the pull request to fix the link or shall we close it?

Also, we need to write better guidelines for creating pull requests so they are easily testable. But ideally:

  1. the commit message should detail what is being done, rather than just which file is being updated. For example: "Remove broken link."
  2. The pull request should confirm steps to review / test / confirm the change has had the desired effect.

I'll see if I can write something today.

In the mean time, let me know if I can help you with this one.

Many thanks,

Finn

@@ -28,7 +28,7 @@ Useful backgound reading:
- [Deployment Workflows for Drupal](https://drupalize.me/topic/deployment-workflows)

For an example on how to install LocalGov Drupal and deploy changes to a development site:
- [Installing and deploying a LocalGov Drupal site](/workflows/installing-and-deploying-lgd)
- [Installing and deploying a LocalGov Drupal site] DEAD LINK
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's set that link to here: https://docs.localgovdrupal.org/devs/getting-started/ instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants