feat: Add support for 'L' flag in list (DOM) #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To allow using it with other days as well. The position should be unimportant.
To ensure it works as intended in combination with other days
Allows to set multiple 'L', and other days of months.
Early return with field instead of big if Block
Instead of looping the day directly in the function, use functions to find the days fitting for the current month, regarding 'L' and 'W' flags. This allows us to set multiple 'L' flags in DOM an DOW, but it may require more (do_next) loops for calculating the next date, as find_next_day may only advance to the next month at most.
Combining L flags and other in DOM and DOW, offsets with L in DOW
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow using it with other days as well. The position should be unimportant.
Multiple
Lflags can be used in DOM and DOW, and combined with other options.