Override defaults for link functions #320
Conversation
|
|
||
| self.bounds = bounds | ||
|
|
||
| def _make_generalized_sigmoid_simple(self, a, b): |
There was a problem hiding this comment.
I think you want to use pytensor operations here no?
At least the linkinv_backend should be pytensor, the others are prob ok.
The example I gave had all pytensor? I think so. (So all pytensor should work either way, since I tested that)
There was a problem hiding this comment.
Actually bambi uses numpy functions, so I just want to make it consistent with other link functions in bambi. https://github.com/bambinos/bambi/blob/main/bambi/families/link.py
There was a problem hiding this comment.
kind of confusing because in the docs for Link it says:
'''
linkinv_backend : function
Same than linkinv but must be something that works with PyMC backend (i.e. it must
work with PyTensor tensors). Does not need to be specified when name is a known
name.
'''
There was a problem hiding this comment.
do numpy --> pt happen automatically?
because without pt it's not going to be differentiable...
There was a problem hiding this comment.
I wouldn't worry too much about this. I basically copied the docs from Bambi, and numpy should be compatible with pytensor. Also, we are not touching linkinv_backend here. Actually none of the bambi-defined link functions uses link_backend
There was a problem hiding this comment.
do numpy --> pt happen automatically? because without pt it's not going to be differentiable...
I think there's some interpretability between numpy and pytensor. Otherwise none of the bambi link functions would work
Updates in this PR:
override_default_linkmethod tohssm.Paramclassoverride_default_linkmethod is called on eachParambefore each Param is finalizeddefaultparameter to hssm.HSSM to control which override strategy to use