Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Posterior predictive plotting #303

Merged
merged 17 commits into from
Oct 25, 2023

Conversation

digicosmos86
Copy link
Collaborator

@digicosmos86 digicosmos86 commented Oct 20, 2023

This PR adds the ability to perform posterior predictive plotting to HSSM. Many other improvements are also included in this PR. The main changes are:

The API design allows for maximum compatibility with matplotlib and seaborn. The plotting functions are designed to be thin wrappers around seaborn histplot and FacetGrid

  • Added the ability to sample posterior predictives from a subset of posterior samples
  • Functions to wrangle arviz InferenceData objects
  • Tests for plotting functions and the above helper functions
  • Restructured tests a bit and removed unnecessary files
  • Documentation for plotting functions

@digicosmos86 digicosmos86 linked an issue Oct 20, 2023 that may be closed by this pull request
Copy link
Collaborator

@AlexanderFengler AlexanderFengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, big pr for adding one (plus a few wrapper) plot(s) :).
Hopefully the infrastructure will prove useful of more plotting stuff.

Left a whole bunch of comments, mostly minor but some things concerning functionality and logic.

Might make sense to meet to clarify.

src/hssm/hssm.py Outdated Show resolved Hide resolved
src/hssm/hssm.py Outdated Show resolved Hide resolved
src/hssm/hssm.py Outdated Show resolved Hide resolved
src/hssm/hssm.py Outdated Show resolved Hide resolved
src/hssm/hssm.py Outdated Show resolved Hide resolved
src/hssm/plotting/posterior_predictive.py Show resolved Hide resolved
src/hssm/plotting/posterior_predictive.py Show resolved Hide resolved
src/hssm/plotting/posterior_predictive.py Show resolved Hide resolved
src/hssm/plotting/utils.py Show resolved Hide resolved
src/hssm/datasets.py Show resolved Hide resolved
@digicosmos86 digicosmos86 merged commit 99dc88a into main Oct 25, 2023
4 checks passed
@digicosmos86 digicosmos86 deleted the 290-graphing-posterior-predictive-plot branch October 25, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Graphing] posterior predictive plot
2 participants