fix: support SW usage #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bumi
reviewed
Mar 20, 2023
|
Yeah |
Co-authored-by: Michael Bumann <[email protected]>
|
Done |
|
Hey @escapedcat I have published a beta module that you can test before I release fully. Could you let me know if that looks all good on your end? |
|
Funny version :) Works! Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We stumbled across this issue in our PR switching the extension to manifest version 3 (MV3).
In MV3 the code is running within a service worker so no
windowexitsts. Not exactly sure where thedocumenterror is coming from but with thsi change it works.What do you think? Would this work for all use cases?