Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix automated layer versioning #64

Merged
merged 13 commits into from
Nov 8, 2024
Merged

Conversation

ncoghlan
Copy link
Collaborator

@ncoghlan ncoghlan commented Nov 1, 2024

First pass at resolving the problem with automated layer versioning breaking venv layering.

Will close #24 when completed

@ncoghlan ncoghlan closed this Nov 4, 2024
@ncoghlan ncoghlan reopened this Nov 4, 2024
github-actions bot added a commit that referenced this pull request Nov 4, 2024
Update expected test output files from automated/expected-output/20241104-045820-e4df1c3 (source PR: #64)
Update expected test output files from automated/expected-output/20241104-045820-e4df1c3 (source PR: #64)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
src/venvstacks/pack_venv.py Outdated Show resolved Hide resolved
src/venvstacks/stacks.py Outdated Show resolved Hide resolved
@ncoghlan
Copy link
Collaborator Author

ncoghlan commented Nov 4, 2024

With the hash updates merged, it looks like the updated build & deployment processes are working, but the sample project tests need to be updated to expect the unversioned names when checking the build environment folders have been created.

@ncoghlan
Copy link
Collaborator Author

ncoghlan commented Nov 4, 2024

The test failures highlighted a deeper problem with the post-install scripts being overly sensitive to how they're executed in the deployed environment: #66

Marking this as BLOCKED until #66 is resolved.

@ncoghlan ncoghlan added the BLOCKED Progress is blocked by an external dependency label Nov 4, 2024
@ncoghlan ncoghlan removed the BLOCKED Progress is blocked by an external dependency label Nov 7, 2024
@ncoghlan
Copy link
Collaborator Author

ncoghlan commented Nov 7, 2024

#66 has been resolved, so this is no longer blocked (but still requires further work)

@ncoghlan ncoghlan marked this pull request as ready for review November 8, 2024 04:00
@ncoghlan ncoghlan closed this Nov 8, 2024
@ncoghlan ncoghlan reopened this Nov 8, 2024
@ncoghlan ncoghlan marked this pull request as draft November 8, 2024 04:06
@ncoghlan ncoghlan marked this pull request as ready for review November 8, 2024 04:06
github-actions bot added a commit that referenced this pull request Nov 8, 2024
Update expected test output files from automated/expected-output/20241108-040045-152524a (source PR: #64)
github-actions bot added a commit that referenced this pull request Nov 8, 2024
Update expected test output files from automated/expected-output/20241108-040631-152524a (source PR: #64)
Update expected test output files from automated/expected-output/20241108-040631-152524a (source PR: #64)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ncoghlan ncoghlan merged commit 42fec53 into main Nov 8, 2024
13 checks passed
@ncoghlan ncoghlan deleted the fix-automatic-layer-versioning branch November 8, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated lock versioning breaks venv layering
1 participant