-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix automated layer versioning #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
added a commit
that referenced
this pull request
Nov 4, 2024
Update expected test output files from automated/expected-output/20241104-045820-e4df1c3 (source PR: #64)
Update expected test output files from automated/expected-output/20241104-045820-e4df1c3 (source PR: #64) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ncoghlan
commented
Nov 4, 2024
With the hash updates merged, it looks like the updated build & deployment processes are working, but the sample project tests need to be updated to expect the unversioned names when checking the build environment folders have been created. |
#66 has been resolved, so this is no longer blocked (but still requires further work) |
github-actions bot
added a commit
that referenced
this pull request
Nov 8, 2024
Update expected test output files from automated/expected-output/20241108-040045-152524a (source PR: #64)
github-actions bot
added a commit
that referenced
this pull request
Nov 8, 2024
Update expected test output files from automated/expected-output/20241108-040631-152524a (source PR: #64)
Update expected test output files from automated/expected-output/20241108-040631-152524a (source PR: #64) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First pass at resolving the problem with automated layer versioning breaking venv layering.
Will close #24 when completed