Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflows: only note reliance on write permissions #57

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Workflows: only note reliance on write permissions #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ jobs:
name: Upload release to PyPI
runs-on: ubuntu-latest
permissions:
contents: read
# Allow use of GitHub OIDC for PyPI authentication
id-token: write
steps:
Expand Down
5 changes: 1 addition & 4 deletions .github/workflows/scan-workflows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,8 @@ jobs:
build:
runs-on: ubuntu-latest
permissions:
# required for all workflows
# Write access needed to upload SARIF scan results
security-events: write
# only required for workflows in private repositories
actions: read
contents: read
steps:
- uses: actions/checkout@v4
with:
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ defaults:
# This also implies `set -eo pipefail` (rather than just `set -e`)
shell: bash

permissions:
contents: read

jobs:
tests:
runs-on: ${{ matrix.os }}
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/update-expected-output.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,6 @@ defaults:
# This also implies `set -eo pipefail` (rather than just `set -e`)
shell: bash

permissions:
contents: read

jobs:
timestamp:
runs-on: ubuntu-20.04
Expand Down Expand Up @@ -178,6 +175,7 @@ jobs:
# Need to check the output for each matrix job separately due to GitHub matrix output limitations
if: needs.test.outputs.want-pr-linux || needs.test.outputs.want-pr-windows || needs.test.outputs.want-pr-macos
permissions:
# Creating PRs involves more than just read permissions
contents: write
pull-requests: write
steps:
Expand Down