Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cache git credentials in workflows #51

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Conversation

ncoghlan
Copy link
Collaborator

Includes a small update to the launch modules in
the sample project so the PR generation for output updates is tested with the updated workflow.

Addresses initial manual workflow scan for #50

Includes a small update to the launch modules in
the sample project so the PR generation for output
updates is tested with the updated workflow.

Addresses initial manual workflow scan for #50
@ncoghlan ncoghlan closed this Oct 29, 2024
@ncoghlan ncoghlan reopened this Oct 29, 2024
Update expected test output files from automated/expected-output/20241029-023608-10eac60 (source PR: #51)

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@ncoghlan
Copy link
Collaborator Author

Workflow scan failure is expected, as the scan result upload won't work until the repo has been published (see the usage caveats in https://docs.github.com/en/code-security/code-scanning/integrating-with-code-scanning/uploading-a-sarif-file-to-github ):

  Warning: Advanced Security must be enabled for this repository to use code scanning.
  Error: Advanced Security must be enabled for this repository to use code scanning.
  Warning: Advanced Security must be enabled for this repository to use code scanning.

All the workflow scan steps prior to that ran as expected.

@ncoghlan ncoghlan merged commit 9da4e56 into main Oct 29, 2024
11 of 12 checks passed
@ncoghlan ncoghlan deleted the run-action-security-scan branch October 29, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant