datapoint count and truncate data #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* eval time progression (#210) * initial work to compare evals * remove unnecessary div * design --------- Co-authored-by: Din <[email protected]> * added datapoint count on dataset table * added types and empty check --------- Co-authored-by: Dinmukhamed Mailibay <[email protected]> Co-authored-by: skull8888888 <[email protected]> Co-authored-by: Din <[email protected]>
* truncate data in datapoints and eval-datapoints * added skeleton --------- Co-authored-by: Robert Kim <[email protected]>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 247fc66 in 1 minute and 35 seconds
More details
- Looked at
341lines of code in10files - Skipped
0files when reviewing. - Skipped posting
4drafted comments based on config settings.
1. app-server/src/db/datapoints.rs:16
- Draft comment:
ChangingdataandtargetfromValuetoStringinDatapointViewmay lead to issues if the database still stores these fields as JSON. Ensure that the database schema and related logic are updated to reflect this change. - Reason this comment was not posted:
Comment did not seem useful.
2. frontend/app/api/projects/[projectId]/datasets/route.ts:55
- Draft comment:
Ensure that thedatapointsCountfield is correctly calculated and included in the dataset response. This field should accurately reflect the number of datapoints associated with each dataset. - Reason this comment was not posted:
Comment did not seem useful.
3. frontend/app/api/projects/[projectId]/evaluations/[evaluationId]/route.ts:42
- Draft comment:
TheSUBSTRINGfunction in SQL should start from index 1, not 0. Update the query toSUBSTRING(data::text, 1, 100)andSUBSTRING(target::text, 1, 100)to correctly truncate the data and target fields. - Reason this comment was not posted:
Marked as duplicate.
4. frontend/app/project/[projectId]/evaluations/[evaluationId]/page.tsx:73
- Draft comment:
TheSUBSTRINGfunction in SQL should start from index 1, not 0. Update the query toSUBSTRING(data::text, 1, 100)andSUBSTRING(target::text, 1, 100)to correctly truncate the data and target fields. - Reason this comment was not posted:
Marked as duplicate.
Workflow ID: wflow_5FnFREkTxU6x7oQ1
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| "SELECT | ||
| id, | ||
| dataset_id, | ||
| SUBSTRING(data::text, 0, 100) as data, |
There was a problem hiding this comment.
The SUBSTRING function in SQL should start from index 1, not 0. Update the query to SUBSTRING(data::text, 1, 100) and SUBSTRING(target::text, 1, 100) to correctly truncate the data and target fields.
| @@ -7,6 +7,26 @@ import { db } from '@/lib/db/drizzle'; | |||
| import { datasetDatapoints } from '@/lib/db/migrations/schema'; | |||
| import { fetcher } from '@/lib/utils'; | |||
|
|
|||
| export async function GET( | |||
There was a problem hiding this comment.
Consider adding authentication and authorization checks in the GET method to ensure that only authorized users can access the datapoint data.
There was a problem hiding this comment.
Handled in middleware
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
This PR truncates
dataandtargetfields to 100 characters, adds datapoint counting, and updates frontend components to handle these changes.datapoints.rs, changedataandtargetfields inDatapointViewfromValuetoString.dataandtargetto 100 characters inget_datapoints().count_datapoints()function to count datapoints indatapoints.rs.GETmethod inroute.tsto fetch a single datapoint by ID.GETindatasets/route.tsto includedatapointsCount.DatasetPanelto fetch and display datapoint details usingswr.datasets.tsxto displaydatapointsCountin datasets table.dataset.tsxto handle datapoint selection and display inDatasetPanel.This description was created by
for 247fc66. It will automatically update as commits are pushed.