added datapoint count on dataset table #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readme fixes and global colors
Update landing and welcome email, contrib experience, minor fixes
Improve onboarding, fix eval page placeholder
Explicit mapping in labels + frontend improvements
Labeling queues
parse litellm attributes (lmnr-ai#171)
add claude-3-5-haiku to pipeline and prices (lmnr-ai#174)
fix evaluations query in labeling queue (lmnr-ai#176)
Middleware auth, traces page efficiency
fixed post requests (lmnr-ai#185)
improve UI for workspaces + internal fixes
Store label values sent from association properties
Playgrounds v0
* initial work to compare evals * remove unnecessary div * design --------- Co-authored-by: Din <[email protected]>
disable all clickhouse queries for non-full builds (lmnr-ai#213)
update models in pipeline templates to 4o family (lmnr-ai#215)
Fix realtime and manual spans
Labeling queues
Semantic search API, blogs, minor fixes
update rust deps and fix blog images (lmnr-ai#246)
Minor fixes in evals
Allow disabling tracing, search by spans
Events and landing
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me! Reviewed everything up to c4cf0bd in 10 seconds
More details
- Looked at
56lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/app/api/projects/[projectId]/datasets/route.ts:55
- Draft comment:
The use ofCOALESCEand casting tointis unnecessary here sinceCOUNT(*)already returns an integer. You can simplify the SQL expression by removingCOALESCEand the cast toint. - Reason this comment was not posted:
Confidence changes required:50%
The SQL query for counting datapoints is correct, but the use ofCOALESCEand casting tointis unnecessary sinceCOUNT(*)already returns an integer. Simplifying this can improve readability.
Workflow ID: wflow_9xSSko7q41uApSNX
You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
There was a problem hiding this comment.
@devansh-m12 looks good overall, quick question: did you test it with empty datasets? By definition SQL's COALESCE may return null, because it returns first non-null value out of its arguments. Just to make sure things are working fine, we should test that case too.
Also, can you set the target branch to dev?
dinmukhamedm
requested changes
Dec 26, 2024
There was a problem hiding this comment.
@devansh-m12 left a small nit. I'll merge this once it's fixed
dinmukhamedm
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #274
@dinmukhamedm added "DataPoints Count" in dataset table, ss for refrence let me know for any changes
Important
Add datapoints count to dataset table in both backend and frontend.
route.ts, addeddatapointsCountto the dataset query using a subquery to count datapoints fromdatasetDatapoints.datasets.tsx, added a new columndatapointsCountto the dataset table to display the count of datapoints.This description was created by
for c4cf0bd. It will automatically update as commits are pushed.