Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prices for newer 4o models #286

Merged
merged 1 commit into from
Dec 21, 2024
Merged

add prices for newer 4o models #286

merged 1 commit into from
Dec 21, 2024

Conversation

dinmukhamedm
Copy link
Member

@dinmukhamedm dinmukhamedm commented Dec 21, 2024

Also changed some var names in instrumentation.ts because seed is slightly different from data initialize


Important

Add pricing for new 4o models and update data initialization in instrumentation.ts.

  • Data Updates:
    • Add pricing for new 4o models gpt-4o-2024-11-20, gpt-4o-audio-preview, and gpt-4o-audio-preview-2024-10-01 in initial-data.json.
  • Code Changes:
    • Rename seed function to initializeData in instrumentation.ts.
    • Rename seedData to initialData in instrumentation.ts.
    • Add onConflictDoNothing to db.insert in instrumentation.ts to handle data conflicts.

This description was created by Ellipsis for 0e05c56. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 0e05c56 in 1 minute and 20 seconds

More details
  • Looked at 159 lines of code in 2 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. frontend/instrumentation.ts:15
  • Draft comment:
    Consider using import instead of require for importing JSON data for consistency and ES module benefits.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The use of require for importing JSON data is not ideal in modern JavaScript/TypeScript. It would be better to use import for consistency and to leverage ES module benefits.

Workflow ID: wflow_UFxCblMn84Oh2XnK


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@dinmukhamedm dinmukhamedm merged commit f43c1a2 into dev Dec 21, 2024
2 checks passed
@dinmukhamedm dinmukhamedm deleted the 4o-nov-24 branch December 21, 2024 04:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant