Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed ui bugs #280

Merged
merged 1 commit into from
Dec 16, 2024
Merged

fixed ui bugs #280

merged 1 commit into from
Dec 16, 2024

Conversation

skull8888888
Copy link
Collaborator

@skull8888888 skull8888888 commented Dec 16, 2024

Important

This pull request fixes UI bugs by updating metadata, enhancing sidebar and navbar functionalities, and removing unused components.

  • Metadata Updates:
    • Updated metadata in layout.tsx to include openGraph and twitter details.
    • Removed redundant metadata from page.tsx.
  • Sidebar and Navbar:
    • Adjusted sidebar state handling in project/[projectId]/layout.tsx to default open if no cookie is set.
    • Enhanced ProjectNavbar in project-navbar.tsx with a new star card feature and updated layout.
    • Removed project-navbar-collapsed.tsx.
  • Component Deletions:
    • Deleted button-scroll-to-bottom.tsx.
  • UI Adjustments:
    • Fixed tab order in traces.tsx.
    • Adjusted row focus styling in datatable.tsx.
    • Updated button variant in header.tsx for "Book a demo" link.
  • Miscellaneous:
    • Minor code style fixes in sidebar.tsx and tooltip.tsx.

This description was created by Ellipsis for 2a8752f. It will automatically update as commits are pushed.

@skull8888888 skull8888888 merged commit 010d99c into dev Dec 16, 2024
2 checks passed
@skull8888888 skull8888888 deleted the ui branch December 16, 2024 12:45
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 2a8752f in 1 minute and 10 seconds

More details
  • Looked at 526 lines of code in 11 files
  • Skipped 0 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. frontend/app/project/[projectId]/layout.tsx:54
  • Draft comment:
    You can simplify the defaultOpen assignment by using optional chaining directly:
defaultOpen = cookieStore.get("sidebar:state")?.value === "true" ?? true;
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The PR includes a change in the frontend/app/project/[projectId]/layout.tsx file where the defaultOpen state for the sidebar is set based on a cookie value. However, the logic can be simplified by using optional chaining directly in the assignment.
2. frontend/components/project/project-navbar.tsx:45
  • Draft comment:
    Consider combining the two useEffect hooks for showStarCard into one to optimize the component:
useEffect(() => {
  if (typeof window !== 'undefined') {
    const saved = localStorage.getItem('showStarCard');
    const initialShowStarCard = saved !== null ? JSON.parse(saved) : true;
    setShowStarCard(initialShowStarCard);
    localStorage.setItem('showStarCard', JSON.stringify(initialShowStarCard));
  }
}, []);
  • Reason this comment was not posted:
    Confidence changes required: 50%
    In the frontend/components/project/project-navbar.tsx file, the useEffect hook for setting showStarCard from localStorage can be optimized by using a single useEffect hook instead of two separate ones.
3. frontend/components/ui/sidebar.tsx:602
  • Draft comment:
    Remove the extra space in the className string for consistency:
"group-focus-within/menu-item:opacity-100 group-hover/menu-item:opacity-100 data-[state=open]:opacity-100 peer-data-[active=true]/menu-button:text-sidebar-accent-foreground md:opacity-0",
  • Reason this comment was not posted:
    Confidence changes required: 50%
    In the frontend/components/ui/sidebar.tsx file, there is an extra space in the className string on line 602. This should be corrected for consistency.

Workflow ID: wflow_A96bn4HkrGV4sU9G


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant