Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

actions: frontend build check on PR commits #275

Merged
merged 6 commits into from
Dec 14, 2024

Conversation

adilb99
Copy link
Contributor

@adilb99 adilb99 commented Dec 8, 2024

Adding a simple build check for PR commits that change anything in the /frontend directory. Added a small comment in the frontend code to test the steps.


Important

Adds GitHub Actions workflow for frontend build checks on PRs affecting /frontend and a comment in layout.tsx.

  • GitHub Actions:
    • Adds fe-build-check.yml to trigger frontend build checks on PRs affecting /frontend.
    • Workflow runs on ubuntu-latest, sets up Node.js, installs pnpm, and builds the frontend.
  • Code Comments:
    • Adds a comment in layout.tsx regarding sidebar state cookies.

This description was created by Ellipsis for 85f581a. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 85f581a in 25 seconds

More details
  • Looked at 59 lines of code in 2 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/fe-build-check.yml:5
  • Draft comment:
    Consider adding the 'edited' event to ensure build checks are triggered when a PR is edited.
    - edited
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable:
    The suggestion to add the 'edited' event could be useful if the intention is to ensure that any edits to the PR trigger the build check. However, this is speculative and not necessarily a required change. The current setup might be sufficient depending on the project's needs. The comment does not indicate a definite issue with the current configuration.
    The comment is speculative and does not point out a definite issue with the current configuration. It suggests a potential improvement but does not provide strong evidence that the change is necessary.
    While the suggestion could be beneficial, it is not a required change and does not address a definite issue. The current configuration might be intentional and sufficient for the project's needs.
    The comment is speculative and does not indicate a definite issue with the current configuration. It should be deleted as it does not meet the criteria for a necessary code change.

Workflow ID: wflow_3Sdf9naSGrwl7sXl


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@adilb99
Copy link
Contributor Author

adilb99 commented Dec 8, 2024

It should only trigger the build if the changes are made in the './frontend` directory to avoid wasting Github Actions if backend changes are committed and etc.

@dinmukhamedm dinmukhamedm merged commit 5774af1 into lmnr-ai:dev Dec 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants