-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename NavigationLink
component to NavigationAction
#1825
Open
crishpeen
wants to merge
2
commits into
integration/header
Choose a base branch
from
fix/navigation-action
base: integration/header
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crishpeen
requested review from
literat,
pavelklibani,
curdaj,
a team and
adamkudrna
as code owners
December 17, 2024 15:18
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
crishpeen
force-pushed
the
fix/navigation-action
branch
3 times, most recently
from
December 17, 2024 15:36
ad13a6e
to
bdec729
Compare
adamkudrna
approved these changes
Dec 17, 2024
packages/web-react/src/components/Navigation/__tests__/useNavigationActionProps.test.ts
Show resolved
Hide resolved
packages/web-react/src/components/UNSTABLE_Header/demo/HeaderWithNavigation.tsx
Outdated
Show resolved
Hide resolved
crishpeen
force-pushed
the
fix/navigation-action
branch
from
December 17, 2024 15:44
bdec729
to
dfe4a60
Compare
crishpeen
force-pushed
the
fix/navigation-action
branch
from
December 17, 2024 15:46
dfe4a60
to
6e5d984
Compare
literat
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional context
Issue reference