Lint Markdown of the form-validations package #1819
Conversation
literat
requested review from
pavelklibani,
curdaj and
a team
as code owners
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| @@ -1,3 +1,6 @@ | |||
| <!-- @see: https://jira.almacareer.tech/browse/DS-1604 --> | |||
| <!--lint disable heading-capitalization--> | |||
There was a problem hiding this comment.
I thought this was solved by the lowerCaseWords option
There was a problem hiding this comment.
No, there is no configuration for this, yet. However, using Web-React seems not correct to me. The package name is web-react, IMHO. And we should use it like everywhere. Or not?
There was a problem hiding this comment.
Wouldn't backticks help?
# `web-react` v2 CodemodsBut the lower-case "v2" is still there, I know.
There was a problem hiding this comment.
@literat, so both v2 and web-react should be in the lowercase config? Or does this not work?
@adamkudrna Nope, till my PR is merged, backticks are ignored, and the content is treated like a generic string
I would consider using our fork of the package until it is merged in upstream.
| @@ -1,3 +1,6 @@ | |||
| <!-- @see: https://jira.almacareer.tech/browse/DS-1604 --> | |||
| <!--lint disable heading-capitalization--> | |||
There was a problem hiding this comment.
Wouldn't backticks help?
# `web-react` v2 CodemodsBut the lower-case "v2" is still there, I know.
Description
Additional context
Issue reference
https://jira.almacareer.tech/browse/DS-1100