Refactor(web-react): Use @local/tests path alias in tests
#1807
+294
−393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
refactoring
✅ Deploy Preview for spirit-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
literat
commented
Dec 10, 2024
| import { classNamePrefixProviderTest } from '../../../../tests/providerTests/classNamePrefixProviderTest'; | ||
| import { restPropsTest } from '../../../../tests/providerTests/restPropsTest'; | ||
| import { stylePropsTest } from '../../../../tests/providerTests/stylePropsTest'; | ||
| import { classNamePrefixProviderTest, restPropsTest, stylePropsTest } from '@local/tests'; |
There was a problem hiding this comment.
todo (if-minor): We need to setup the correct import order. Maybe @curdaj can help with it.
✅ Deploy Preview for spirit-design-system-storybook ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
literat
commented
Dec 10, 2024
|
|
||
| // A map from regular expressions to module names or to arrays of module names | ||
| // https://jestjs.io/docs/configuration#modulenamemapper-objectstring-string--arraystring | ||
| moduleNameMapper: { |
There was a problem hiding this comment.
suggestion (if-minor): Consider using ts-jest and https://kulshekhar.github.io/ts-jest/docs/getting-started/paths-mapping/
literat
commented
Dec 10, 2024
literat
force-pushed
the
refactor/tests-import-alias
branch
from
a8ac61a to
8be5e9c
Compare
literat
commented
Dec 17, 2024
| @@ -73,9 +88,14 @@ module.exports = { | |||
| { | |||
| groups: ['builtin', 'external', 'internal', 'parent', 'sibling', 'index'], | |||
| pathGroups: [ | |||
| // { | |||
There was a problem hiding this comment.
thought (if-minor): It looks like this option have no effect on the current code. @curdaj
…ock between tests
literat
force-pushed
the
refactor/tests-import-alias
branch
from
26e8293 to
a12fbac
Compare
…eIcon mock between tests
literat
requested review from
pavelklibani,
curdaj and
a team
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
testsdirectory@local/testspath alias - tsconfig + ESlintuseIconmock because of path changes and crazy Jest and JavaScript mock hoistingdata-testId->data-testidAdditional context
I suggest doing a review per commit. The settings themselves are in different commits than changes in test files.
Issue reference
https://jira.almacareer.tech/browse/DS-1611
https://jira.almacareer.tech/browse/DS-1612