Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(web-react): Responsive Card layout #DS-1559 #1802

Merged
merged 3 commits into from
Dec 12, 2024
Merged

Feat(web-react): Responsive Card layout #DS-1559 #1802

merged 3 commits into from
Dec 12, 2024

Conversation

pavelklibani
Copy link
Contributor

Description

Additional context

Issue reference

@pavelklibani pavelklibani self-assigned this Dec 9, 2024
@pavelklibani pavelklibani changed the base branch from main to integration/card December 9, 2024 16:29
@netlify Netlify
Copy link

netlify bot commented Dec 9, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system-storybook canceled.

Name Link
🔨 Latest commit fb6a814
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/675aff4da3f47c00084f5da3

@netlify Netlify
Copy link

netlify bot commented Dec 9, 2024 •
edited
Loading

✅ Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit fb6a814
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/675aff4de2c9eb0008016c34
😎 Deploy Preview https://deploy-preview-1802--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavelklibani pavelklibani force-pushed the feat/ds-1559-react-responsive-card-layout branch from 32d8204 to 7d06770 Compare December 10, 2024 08:34
@pavelklibani pavelklibani marked this pull request as ready for review December 10, 2024 10:39
@pavelklibani pavelklibani requested review from literat, curdaj and a team as code owners December 10, 2024 10:39
@pavelklibani pavelklibani changed the title Feat(web-react): Responsive card layout #DS-1559 Feat(web-react): Responsive Card layout #DS-1559 Dec 10, 2024
adamkudrna
adamkudrna reviewed Dec 10, 2024
View reviewed changes
Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! 👍🏻

All I'm missing is the new CSS (the CSS classes are correct, but the responsive styles are missing), but I assume a rebase will fix it.

image

docs/DICTIONARIES.md Outdated Show resolved Hide resolved
packages/web-react/src/components/Card/README.md Outdated Show resolved Hide resolved
@pavelklibani
Copy link
Contributor Author

Beautiful! 👍🏻

All I'm missing is the new CSS (the CSS classes are correct, but the responsive styles are missing), but I assume a rebase will fix it.

image

Yes, it should be fixed when rebased with your changes

@pavelklibani pavelklibani added the run-visual-tests Runs visual regression testing on this PR label Dec 11, 2024
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12274032287/artifacts/2304909490

@pavelklibani pavelklibani force-pushed the feat/ds-1559-react-responsive-card-layout branch from a0f271e to c0fcadf Compare December 11, 2024 10:18
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12274282244/artifacts/2304988768

@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12284876662/artifacts/2308322668

@pavelklibani pavelklibani force-pushed the feat/ds-1559-react-responsive-card-layout branch from ae1d602 to 5ad2bee Compare December 12, 2024 08:37
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12292690860/artifacts/2310424676

@pavelklibani pavelklibani force-pushed the feat/ds-1559-react-responsive-card-layout branch from 5ad2bee to 5cb4206 Compare December 12, 2024 15:10
@github-actions GitHub Actions
Copy link
Contributor

Here is the URL of the uploaded artifact: https://github.com/lmc-eu/spirit-design-system/actions/runs/12299230479/artifacts/2312366527

@pavelklibani pavelklibani force-pushed the feat/ds-1559-react-responsive-card-layout branch from 5cb4206 to fb6a814 Compare December 12, 2024 15:20
@pavelklibani pavelklibani merged commit 5234cd7 into integration/card Dec 12, 2024
20 checks passed
@pavelklibani pavelklibani deleted the feat/ds-1559-react-responsive-card-layout branch December 12, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkudrna adamkudrna adamkudrna approved these changes

@literat literat literat approved these changes

@curdaj curdaj Awaiting requested review from curdaj

Assignees

@pavelklibani pavelklibani

Labels
run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelklibani @literat @adamkudrna