Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(web, web-react): Add minimalistic Footer demo #DS-1574 #1800

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

pavelklibani
Copy link
Contributor

@pavelklibani pavelklibani commented Dec 4, 2024

Description

Adding new minimalistic footer demo

image

Additional context

  • Added styling props to Footer component
    • backgroundColor, paddingBottom, paddingTop

Issue reference

Component Footer | Demo of minimalistic Footer

@pavelklibani pavelklibani self-assigned this Dec 4, 2024
@github-actions github-actions bot added the feature New feature or request label Dec 4, 2024
Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for spirit-design-system-storybook ready!

Name Link
🔨 Latest commit 33fc104
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system-storybook/deploys/675b02808adc9400087ce5e7
😎 Deploy Preview https://deploy-preview-1800--spirit-design-system-storybook.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Dec 4, 2024

Deploy Preview for spirit-design-system ready!

Name Link
🔨 Latest commit 33fc104
🔍 Latest deploy log https://app.netlify.com/sites/spirit-design-system/deploys/675b02803c11bb0008aa0c94
😎 Deploy Preview https://deploy-preview-1800--spirit-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 96 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@pavelklibani pavelklibani force-pushed the feat/ds-1574-minimalistic-footer branch 2 times, most recently from 00d2504 to 13ab275 Compare December 5, 2024 09:39
@pavelklibani pavelklibani added the run-visual-tests Runs visual regression testing on this PR label Dec 5, 2024
Copy link
Collaborator

@literat literat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@pavelklibani pavelklibani force-pushed the feat/ds-1574-minimalistic-footer branch from 5d113bf to fb981d3 Compare December 10, 2024 15:08
@pavelklibani
Copy link
Contributor Author

rebased & solve conflict

Copy link
Contributor

Copy link
Contributor

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍🏻

@pavelklibani pavelklibani force-pushed the feat/ds-1574-minimalistic-footer branch 3 times, most recently from b175add to 1033ef1 Compare December 12, 2024 12:50
@pavelklibani pavelklibani force-pushed the feat/ds-1574-minimalistic-footer branch from 1033ef1 to 33fc104 Compare December 12, 2024 15:34
@pavelklibani pavelklibani merged commit b58db79 into main Dec 12, 2024
23 checks passed
@pavelklibani pavelklibani deleted the feat/ds-1574-minimalistic-footer branch December 12, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request run-visual-tests Runs visual regression testing on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants